This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rGf12cd99c440a: [clangd] Config: compile Fragment ->
CompiledFragment -> Config (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D8261
sammccall marked 8 inline comments as done.
sammccall added a comment.
Thanks a lot for the review, I think this is a lot better now.
And particularly on where docs are lacking - I'm happy to write comments but
it's hard for me to know which bits are least clear.
Comment at: c
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, looks good.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65
+if (F.HasUnrecognizedCondition)
+ Conditions.push_back([&](const Params &) { return fa
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65
+if (F.HasUnrecognizedCondition)
+ Conditions.push_back([&](const Params &) { return false; });
+
hokein wrote:
> sammccall wrote:
> > hokein wrote:
> > > I think
sammccall updated this revision to Diff 274623.
sammccall marked 13 inline comments as done.
sammccall added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82612/new/
https://reviews.llvm.org/D82612
Files:
clang-tools-
hokein added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65
+if (F.HasUnrecognizedCondition)
+ Conditions.push_back([&](const Params &) { return false; });
+
sammccall wrote:
> hokein wrote:
> > I think if this case happened,
sammccall updated this revision to Diff 274503.
sammccall added a comment.
CompiledFragment becomes a std::function, compile interface moved to Fragment.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82612/new/
https://reviews.llvm.org/D82612
Fil
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ConfigProvider.h:47
+ /// This always produces a usable compiled fragment (errors are recovered).
+ explicit CompiledFragment(Fragment, DiagnosticCallback);
+
-
sammccall updated this revision to Diff 274470.
sammccall marked an inline comment as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82612/new/
https://reviews.llvm.org/D82612
Files:
clang-tools-e
sammccall marked 8 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CMakeLists.txt:41
+ ConfigCompile.cpp
ConfigYAML.cpp
Diagnostics.cpp
hokein wrote:
> sammccall wrote:
> > hokein wrote:
> > > we have a few co
hokein added inline comments.
Comment at: clang-tools-extra/clangd/CMakeLists.txt:41
+ ConfigCompile.cpp
ConfigYAML.cpp
Diagnostics.cpp
sammccall wrote:
> hokein wrote:
> > we have a few config-related files now, I wonder would it make sense to
> > create
sammccall marked 10 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CMakeLists.txt:41
+ ConfigCompile.cpp
ConfigYAML.cpp
Diagnostics.cpp
hokein wrote:
> we have a few config-related files now, I wonder would i
sammccall updated this revision to Diff 274237.
sammccall marked 3 inline comments as done.
sammccall added a comment.
Address some review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82612/new/
https://reviews.llvm.org/D82612
Files:
c
hokein added inline comments.
Comment at: clang-tools-extra/clangd/CMakeLists.txt:41
+ ConfigCompile.cpp
ConfigYAML.cpp
Diagnostics.cpp
we have a few config-related files now, I wonder would it make sense to create
a config/ subdir?
Com
sammccall created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov, mgorny.
Herald added a project: clang.
sammccall added a parent revision: D82606: [clangd] Config: config struct
propagated through Context.
sammccall edited the
15 matches
Mail list logo
