[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

2020-06-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. As the warnings suggest, nested name definitions can't be used because llvm-project is still using C++14. `llvm.org` as a reviewer doesn't work. You can use `git log` and find acti

[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

2020-06-25 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Isn't that C++17? LLVM is at C++14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82604/new/ https://reviews.llvm.org/D82604 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

2020-06-25 Thread Seija Kijin via Phabricator via cfe-commits
pi1024e created this revision. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. A lot of the code, including ironically the nested namespace checker itself, was using "namespace clang { tidy { modernize...", so I put those together for readability as "namespace cla