[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 292469. djtodoro added a comment. - Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 277781. djtodoro added a comment. Herald added a subscriber: dang. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 276398. djtodoro added a comment. - Rebase on top of D83391 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: djtodoro wrote: > vsk wrote: > > Please factor out OptCustomPassMa

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: vsk wrote: > Please factor out OptCustomPassManager from opt and g

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

vsk requested changes to this revision. vsk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: Please factor out OptCustom

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ aprantl wrote: > I think this is redundant?

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274690. djtodoro added a comment. - Remove redundant line from the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/Code

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ I think

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274433. djtodoro added a comment. - Add the Driver test - Remove the old high level test in order to avoid troubles when someone updates an LLVM pass with the impact on Debugify output (e.g. a new debug info bugs) - clang-formatted CHANGES SINCE LAST ACTI

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse Co

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation: {{.*}} -

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: > ap

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274054. djtodoro added a comment. -Update the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: > We probably shouldn't check the effects of LLV

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS We probably shouldn't check the effects of LLVM passes in the C

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro created this revision. djtodoro added reviewers: vsk, aprantl, dblaikie, probinson. djtodoro added projects: debug-info, LLVM. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. djtodoro added a parent revision: D82546: [Debugify][OriginalMode] Export the