This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5547a83c0b68: [CodeComplete] Add code completion for using
alias. (authored by kadircet).
Repository:
rG LLVM Github Mo
lh123 updated this revision to Diff 273631.
lh123 added a comment.
Rebase to head.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82535/new/
https://reviews.llvm.org/D82535
Files:
clang/lib/Sema/SemaCodeComplete.cpp
clang/test/CodeCompletion/or
kadircet requested changes to this revision.
kadircet added a comment.
This revision now requires changes to proceed.
this seems to be failing to merge, could you rebase on top of head?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82535/new/
https
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Will land this one too. In the meantime feel free to apply for commit access,
as explained in
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access (IIRC, you
lh123 updated this revision to Diff 273321.
lh123 marked 3 inline comments as done.
lh123 added a comment.
Address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82535/new/
https://reviews.llvm.org/D82535
Files:
clang/lib/Sema/SemaCodeCo
kadircet added a comment.
mostly LG, apart from the comments around the fallthrough, thanks!
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2061
+if (SemaRef.getLangOpts().CPlusPlus11)
+ AddUsingAliasResult(Results);
there's already a fallthrough do
lh123 updated this revision to Diff 273287.
lh123 added a comment.
format code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82535/new/
https://reviews.llvm.org/D82535
Files:
clang/lib/Sema/SemaCodeComplete.cpp
clang/test/CodeCompletion/ordin
lh123 created this revision.
lh123 added a reviewer: kadircet.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
lh123 added a parent revision: D82373: [CodeComplete] Tweak code completion for
`typename`..
Add code completion for using alias.
Repository:
rG LLVM Github Mo
