This revision was automatically updated to reflect the committed changes.
Closed by commit rG8013ce449022: [HIP] Add missing options for lto (authored by
yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D82506?vs=273424&id=273588#toc
Repository:
rG LL
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82506/new/
https://reviews.llvm.org/D82506
___
cfe-commits mailing list
cfe-commits@lists.
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:76
+MAttrString.append(Args.MakeArgString(OneFeature));
+if (OneFeature != Features.back())
+ MAttrString.append(",");
tra wrote:
>
yaxunl updated this revision to Diff 273424.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Herald added subscribers: kerbowa, nhaehnle, jvesely.
Fix issue about -mattr. Also use generic LTO option translation and use
-plugin-opt.
CHANGES SINCE LAST ACTION
https://reviews.ll
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:76
+MAttrString.append(Args.MakeArgString(OneFeature));
+if (OneFeature != Features.back())
+ MAttrString.append(",");
I think StringRef will result in comparison by value. If
yaxunl created this revision.
yaxunl added reviewers: tra, arsenm, ashi1.
Herald added subscribers: dexonsmith, inglorion, wdng.
Add -mcpu, -mattr, -mllvm, and -save-temps options for lto when necessary.
https://reviews.llvm.org/D82506
Files:
clang/lib/Driver/ToolChains/HIP.cpp
clang/test/D
