kadircet added a comment.
For the record:
http://llvm-compile-time-tracker.com/compare.php?from=ed8184b7814df4310dbad065a9a1c3bb8f3bfa86&to=408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3&stat=instructions
https://photos.app.goo.gl/fJUS5jrMaJjvvmo1A
Repository:
rG LLVM Github Monorepo
CHANGES SINC
This revision was automatically updated to reflect the committed changes.
Closed by commit rG408efffbe4a5: [Clang][SourceManager] optimize
getFileIDLocal() (authored by nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82497/new/
https
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Btw, I've recently learned about http://llvm-compile-time-tracker.com/ so you
might want to check the effect afterwards.
Repository:
rG LLVM Github Monorepo
CHANGES SINC
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: kadircet.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A recent Linux kernel commit exposed a performance cliff in Clang. Calls
to SourceManager::getFileIDLocal() when there's a cache miss against
La
