[PATCH] D82446: [clang] Fix duplicate warning

2020-06-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions, Actions.getASTContext().getPrintingPolicy()); return false; kamleshb

[PATCH] D82446: [clang] Fix duplicate warning

2020-06-24 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. I apologise for a quick drive-by comment, but this is something I find very annoying when looking at the history of a piece of code: Could you spent a few minutes to make a more descriptive title and description? Fixes duplicate warning emitted by clang when char

[PATCH] D82446: [clang] Fix duplicate warning

2020-06-24 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui marked an inline comment as done. kamleshbhalui added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions, Actions.getASTContext().getPrintingPolic

[PATCH] D82446: [clang] Fix duplicate warning

2020-06-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions, Actions.getASTContext().getPrintingPolicy()); return false; This cha

[PATCH] D82446: [clang] Fix duplicate warning

2020-06-24 Thread kamlesh kumar via Phabricator via cfe-commits
kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes duplicate warning emitted by clang when char16_t/char32_t is used in the catch block. Fixes this https://bugs.llvm.org/show_bug.