This revision was automatically updated to reflect the committed changes.
Closed by commit rGf531c1c7c0d5: [analyzer] Introduce small improvements to the
solver infra (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
vsavchenko updated this revision to Diff 278454.
vsavchenko added a comment.
Rename function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
https://reviews.llvm.org/D82381
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/R
ASDenysPetrov added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:734
//expressions which we currently do not know how to negate.
- const RangeSet *getRangeForMinusSymbol(ProgramStateRef State, SymbolRef Sym)
{
+ Optional getR
NoQ accepted this revision.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:734
//expressions which we currently do not know how to negate.
- const RangeSet *getRangeForMinusSymbol(ProgramStateRef State, SymbolRef Sym)
ASDenysPetrov added a comment.
@vsavchenko
OK, let it be. )
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
https://reviews.llvm.org/D82381
___
cfe-commits mailing list
cfe-commits@lists.llvm
vsavchenko marked 2 inline comments as done.
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:734
//expressions which we currently do not know how to negate.
- const RangeSet *getRangeForMinusSymbol(ProgramStateRef
ASDenysPetrov added a comment.
@vsavchenko
Thank you.
Despite of all of my nits, LGTM!
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:367-378
+RangeSet RangeSet::Delete(BasicValueFactory &BV, Factory &F,
+ const llvm::APSInt &Point
vsavchenko marked 3 inline comments as done.
vsavchenko added a comment.
Hi @ASDenysPetrov no problem at all! Thanks for taking your time and checking
it.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:367-378
+RangeSet RangeSet::Delete(BasicValueFactory
ASDenysPetrov added a comment.
Hi @vsavchenko , sorry for the late review.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:367-378
+RangeSet RangeSet::Delete(BasicValueFactory &BV, Factory &F,
+ const llvm::APSInt &Point) const {
+
vsavchenko updated this revision to Diff 275955.
vsavchenko added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
https://reviews.llvm.org/D82381
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedCons
vsavchenko marked an inline comment as done.
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:373
+ ++Upper;
+ --Lower;
+
xazax.hun wrote:
> Sorry if my question is dumb, but I do not really have a mental mo
vsavchenko marked an inline comment as done.
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:467-470
+/// Available representations for the arguments are:
+/// * RangeSet
+/// * Optional
+/// * RangeSet *
--
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:373
+ ++Upper;
+ --Lower;
+
Sorry if my question is dumb, but I do not really have a mental model at this
point about where do we actually handle types and ov
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:467-470
+/// Available representations for the arguments are:
+/// * RangeSet
+/// * Optional
+/// * RangeSet *
Why do we have these representations in the first
vsavchenko marked an inline comment as done.
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:556
RangeSet infer(SymbolRef Sym) {
-const RangeSet *AssociatedRange = State->get(Sym);
-
-// If Sym is a difference of s
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:556
RangeSet infer(SymbolRef Sym) {
-const RangeSet *AssociatedRange = State->get(Sym);
-
-// If Sym is a difference of symbols A - B, then maybe we have range set
-// s
vsavchenko updated this revision to Diff 272729.
vsavchenko added a comment.
Add forgotten nodiscards
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
https://reviews.llvm.org/D82381
Files:
clang/include/clang/StaticAnalyzer/Core/PathSe
vsavchenko updated this revision to Diff 272724.
vsavchenko added a comment.
Fix comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
https://reviews.llvm.org/D82381
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/Range
vsavchenko updated this revision to Diff 272722.
vsavchenko added a comment.
Remove hunk that is meant for the next commmit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82381/new/
https://reviews.llvm.org/D82381
Files:
clang/include/clang/Stat
vsavchenko created this revision.
vsavchenko added reviewers: NoQ, dcoughlin, ASDenysPetrov, xazax.hun, Szelethus.
Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
Herald added a project: clang.
- Add a
20 matches
Mail list logo
