[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2125713 , @lxfind wrote: > In D82314#2124662 , @junparser wrote: > > > In D82314#2124661 , @junparser > > wrote: > > > > > @lxfind This

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

lxfind added a comment. In D82314#2124662 , @junparser wrote: > In D82314#2124661 , @junparser wrote: > > > @lxfind This patch causes some mismatch when variable is used in both > > resume and destroy function. Bes

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. @lxfind This patch causes some mismatch when variable is used in both resume and destroy function. Besides, we should move this patch and the check in buildCoroutineFrame. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2124661 , @junparser wrote: > @lxfind This patch causes some mismatch when variable is used in both resume > and destroy function. Besides, we should move this patch and the check in > buildCoroutineFrame. @lxfind,

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM， Thank you！ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 _

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8755b6378c2: [Coroutines] Optimize the lifespan of temporary co_await object (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

lxfind updated this revision to Diff 273946. lxfind added a comment. Rebase before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 Files: llvm/lib/Transforms/Coroutines/CoroSplit.cpp llvm/test/T

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

lxfind added a comment. In D82314#2117543 , @lewissbaker wrote: > > There are still room for improvements, in particular, GCC has a 4K frame > > for this function. > > I think GCC having a smaller coroutine frame is probably because it does not > yet i