[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

c-rhodes added a comment. In D82178#2106847 , @fpetrogalli wrote: > LGTM! Thanks. Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178 ___

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8fae2bb4afe: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE (authored by c-rhodes). Changed prior to commit: https://reviews.llvm.org/D82178?vs=272091&id=272664#toc Repository: rG LLVM

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Comment at: clang/utils/TableGen/SveEmitter.cpp:1092 + OS << "#if !defined(__ARM_FEATURE_BF16_SCALAR_ARITHMETIC)\n"; + OS << "#error \"__ARM_FEATURE

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

c-rhodes updated this revision to Diff 272091. c-rhodes added a comment. Changes: - Include `arm_bf16.h` if `__ARM_FEATURE_BF16_SCALAR_ARITHMETIC` is defined. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178 Files: clang/include/clang/Basic/ar

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

fpetrogalli added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1092 + OS << "#if !defined(__ARM_FEATURE_BF16_SCALAR_ARITHMETIC)\n"; + OS << "#error \"__ARM_FEATURE_BF16_SCALAR_ARITHMETIC must be defined when " +"__ARM_FEATURE_SVE_BF16 is defined\"\n"

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

c-rhodes updated this revision to Diff 272043. c-rhodes added a comment. Changes: - Error if `__ARM_FEATURE_BF16_SCALAR_ARITHMETIC` not defined when defining `__ARM_FEATURE_SVE_BF16`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178 Files: cl

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1091 + OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n"; + OS << "typedef __SVBFloat16_t svbfloat16_t;\n"; + OS << "#endif\n\n"; Can you also add an error if `__ARM_FEATURE_SVE_BF16`

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, efriedma, stuij, fpetrogalli. Herald added subscribers: cfe-commits, danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. sdesmalen added inline comments. =