[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a548bc203cf: [clang-tidy] modernize-loop-convert reverse iteration support (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 __

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 294897. njames93 marked an inline comment as done. njames93 added a comment. IsReverse= Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clan

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 294895. njames93 added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clang-tidy/modernize/LoopConvert

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:1011-1015 + if (Header.front() == '<' && Header.back() == '>') { +IsSystemInclude = true; +Header.pop_back(); +Header.erase(0, 1); + } alexfh wrot

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thanks for the patch! Looks generally good. A few comments inline. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:74-76 +static const char

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 282757. njames93 added a comment. - Rebased trunk - Cleaned up test cases - Added support for specifying to include as system include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.l

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 278398. njames93 added a comment. Updated release notes for version bump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clang-tidy/moderni

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 273913. njames93 added a comment. Rebased inline with new enum handling added in D82188 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D820

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 272034. njames93 added a comment. Add documentation about the include style optione Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clang-ti

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 272030. njames93 added a comment. - Set and store the IncludeStyle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tools-extra/clang-tidy/modernize/Loop

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 added a comment. In D82089#2100802 , @Eugene.Zelenko wrote: > It'll be interesting to run improved check over LLVM code base. I haven't tried running it over llvm, but I have had success using it with clangd in my editor, every loop I've tried

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 271856. njames93 added a comment. - Change default c++20 include to `ranges` instead of `algorithm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tool

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 271723. njames93 marked 4 inline comments as done. njames93 added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

Eugene.Zelenko added a comment. It'll be interesting to run improved check over LLVM code base. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:983 +const LangOptions &LangOpts) +: IsEnabled(false), UseCxx20IfAvailable(UseCxx20IfAvailable), +

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 created this revision. njames93 added reviewers: alexfh, Eugene.Zelenko, angelgarcia, aaron.ballman, klimek. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Enables support for transforming loops of the form for (auto I = Cont.rbegin(), E = Cont.rend()