[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

This revision was automatically updated to reflect the committed changes. Closed by commit rGccd127008aa2: [clang-tidy] warnings-as-error no longer exits with ErrorCount (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81953/new/

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

aaron.ballman added a comment. In D81953#2096635 , @njames93 wrote: > In D81953#2096388 , @aaron.ballman > wrote: > > > LGTM unless @jroelofs has a reason why the code was originally written that > > way, but can

Re: [PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

I didn’t have a specific use case in mind for it, so no preference either way. LGTM as well On Tue, Jun 16, 2020 at 1:05 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman accepted this revision. > aaron.ballman added a comment. > This revision is now accepted an

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

njames93 added a comment. In D81953#2096388 , @aaron.ballman wrote: > LGTM unless @jroelofs has a reason why the code was originally written that > way, but can you add test coverage for it? How would you suggest I add test coverage for this, afaik llv

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM unless @jroelofs has a reason why the code was originally written that way, but can you add test coverage for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

lebedev.ri added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81953/new/ https://reviews.llvm.org/D81953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

njames93 created this revision. njames93 added reviewers: alexfh, jroelofs, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. When using `-warnings-as-errors`, If there are any warnings promoted to errors, clang-tidy exits with the number of warnings.