[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG14b947f306ac: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ ht

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko updated this revision to Diff 271073. vsavchenko added a comment. Add FIXME comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ https://reviews.llvm.org/D81916 Files: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp cla

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:131 const Token &T = FilteredTokens.back(); - if (!T.isLiteral()) + if (!T.isLiteral() || !T.getLiteralData()) return llvm::None;

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

martong added a comment. In D81916#2095106 , @NoQ wrote: > Thanks! > > @martong, thoughts on this? :) > > Also i guess in this test we're unable to obtain the value for `EOF`, what > would be a good fixme-test to demonstrate that? I accept this as a ver

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko marked 5 inline comments as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/pch_crash.cpp:1 +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.15.0 -emit-pch -o %t %s +// RUN: %clang_analyze_cc1 -triple x86_64-apple-macosx10.15.0 -include-pch %t

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko updated this revision to Diff 271005. vsavchenko added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81916/new/ https://reviews.llvm.org/D81916 Files: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp c

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

NoQ added inline comments. Comment at: clang/test/Analysis/pch_crash.cpp:21 + // we need a function call here to initiate erroneous routine + return foo(); +} NoQ wrote: > Let's add sone comment like `// no-crash` so that to indicate what is it that > we're te

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! @martong, thoughts on this? :) Also i guess in this test we're unable to obtain the value for `EOF`, what would be a good fixme-test to demonstrate that? Comment at: cla

[PATCH] D81916: [analyzer] Fix StdLibraryFunctionsChecker crash on macOS

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. vsavchenko added a