[PATCH] D81886: [AMDGPU] Add gfx1030 target

2021-06-25 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1245 + +def HasDsSrc2Insts : Predicate<"!Subtarget->hasDsSrc2Insts()">, + AssemblerPredicate<(all_of FeatureDsSrc2Insts)>; foad wrote: > The `!` is obviously wrong in this definition, b

[PATCH] D81886: [AMDGPU] Add gfx1030 target

2021-06-25 Thread Jay Foad via Phabricator via cfe-commits
foad added inline comments. Herald added a subscriber: dexonsmith. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1245 + +def HasDsSrc2Insts : Predicate<"!Subtarget->hasDsSrc2Insts()">, + AssemblerPredicate<(all_of FeatureDsSrc2Insts)>; The `!` is obviously wrong

[PATCH] D81886: [AMDGPU] Add gfx1030 target

2020-06-18 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec marked an inline comment as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:266-267 names. + ``gfx1030`` ``amdgcn`` dGPU - xnack

[PATCH] D81886: [AMDGPU] Add gfx1030 target

2020-06-17 Thread Jay Foad via Phabricator via cfe-commits
foad added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:266-267 names. + ``gfx1030`` ``amdgcn`` dGPU - xnack *TBA* +