[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

This revision was automatically updated to reflect the committed changes. saghir marked an inline comment as done. Closed by commit rGf4c337ab85c0: [PowerPC] Add support for vector bool __int128 for Power10 (authored by saghir). Changed prior to commit: https://reviews.llvm.org/D81816?vs=271874

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei accepted this revision as: lei. lei added a comment. LGTM, please address the 1 comment I have on commit. Comment at: clang/test/Parser/altivec-bool-128.c:6 +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-cpu pwr10 \ +// RUN:-target-feature +al

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:6 +// RUN:-target-feature +power10-vector -fsyntax-only -verify %s +// expected-no-diagnostics + amyk wrote: > I believe this co

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

amyk accepted this revision as: amyk. amyk added a comment. Other than Lei's concerns, personally I think this looks good to me. Comment at: clang/test/Parser/p10-vector-bool-128.c:6 +// RUN:-target-feature +power10-vector -fsyntax-only -verify %s +// expected-no-di

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271874. saghir added a reviewer: stefanp. saghir added a comment. Updated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/Dia

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271860. saghir edited the summary of this revision. saghir added a comment. Updated comment to reflect the change in allowed types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.o

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271498. saghir marked an inline comment as done. saghir added a comment. Updated tests features to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-featu

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1170 // Only 'short' and 'long long' are valid with vector bool. (PIM 2.1) if ((TypeSpecWidth != TSW_unspecified) && (TypeSpecWidth != TSW_short) &&

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 3 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector bo

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271459. saghir marked 2 inline comments as done. saghir added a comment. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basi

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271164. saghir added a comment. Updated comment for allowing __int128 for vector bool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1170 // Only 'short' and 'long long' are valid with vector bool. (PIM 2.1) if ((TypeSpecWidth != TSW_unspecified) && (TypeSpecWidth != TSW_short) && Do we not need to add a check f

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector bool for Power10. saghir wrot

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271144. saghir added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei added inline comments. Comment at: clang/test/Parser/altivec-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feature +altivec -fsyntax-on

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/DeclSpec.cpp clang/test/Parser/altivec

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 4 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector bo

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

lei requested changes to this revision. lei added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

amyk added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:1 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple=powerpc64le-unknown-linux-gnu -target-feat

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir created this revision. saghir added reviewers: PowerPC, hfinkel. saghir added projects: LLVM, PowerPC. Herald added subscribers: cfe-commits, shchenz, nemanjai. Herald added a project: clang. saghir added a parent revision: D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.