[PATCH] D81672: [Driver] When forcing a crash print the bug report message

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1fa201af77: [Driver] When forcing a crash print the bug report message (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

jhenderson accepted this revision. jhenderson added a comment. Latest version LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn updated this revision to Diff 273816. john.brawn edited the summary of this revision. john.brawn added a comment. Don't print the diagnostic with -gen-reproducer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 Files: clang/test/Dri

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > john.brawn wrote: > > MaskRay wrote: > > > Why ` llvm::dbgs() <<

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } john.brawn wrote: > MaskRay wrote: > > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is > > specified? Th

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reprod

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is specified? The user requests to generate a reproduce fil

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL MaskRay wrote: > This variable is mutable

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, but wait for others too, please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL This variable is mutable. Please use `const char BugReportMsg[]` CHANGES SINCE LAST ACT

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn updated this revision to Diff 272471. john.brawn retitled this revision from "[Driver] When forcing a crash call abort to get the correct diagnostic" to "[Driver] When forcing a crash print the bug report message". john.brawn edited the summary of this revision. john.brawn added a comm