[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm closed this revision. arsenm added a comment. Merged with D83518 as 5e999cbe8db0b50dc9828a1c062b4ffe84c5b137 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm added a comment. I did realize one edge case that is different between carrying the size and the type. You can have a zero sized type with an alignment, but 0 is naturally an invalid value for the attribute (and all the others that carry an integer) CHANGES SINCE LAST ACTION https://r

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list cfe

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

jdoerfert added a comment. LGTM, @rjmccall wdyt? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm updated this revision to Diff 271732. arsenm retitled this revision from "[RFC] LangRef: Define inmem parameter attribute" to "[RFC] LangRef: Define byref parameter attribute". arsenm added a comment. Rename to byref. Specify more explicitly this is for the ABI, and should not be inferred