This revision was automatically updated to reflect the committed changes.
Closed by commit rGf693ce4aa97e: [clangd] Change ParseInputs to store
FSProvider rather than VFS (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81173/new
kadircet updated this revision to Diff 269168.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Inline VFS uses in ClangdServer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81173/new/
https://reviews.llvm.org/D81173
Files:
kadircet updated this revision to Diff 269161.
kadircet added a comment.
- Rebase
- Move GetFSProvider to a lambda inside scanPreamble with a FIXME.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81173/new/
https://reviews.llvm.org/D81173
Files:
sammccall added a comment.
Let's land this and do further refactoring/renames later.
As you mentioned, it's not possible to inline some of the cases where raw
pointers are e.g. stored in structs due to lifetime issues. I expect many of
these to go away once we use FSProvider more pervasively.
sammccall added a comment.
Hmm, having looked at this it is a bit of a mess, but I think partly because
we're not converting *enough* code to use this abstraction (e.g. the preamble
caching stuff, or prepareCompilerInstance).
We should work how how to get the bugfix part of this landed, but I th
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
javed.absar, ilya-biryukov.
Herald added a project: clang.
This ensures ParseInputs provides a read-only access to FS.
Repository:
rG LLVM Github
