[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

MaskRay added a comment. @eduucaldas Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differentia

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2f6b4a08ba: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271784. eduucaldas added a comment. change if -> asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:182 + for (auto *C = firstChild(); C; C = C->nextSibling()) { +if (C->role() == syntax::NodeRole::NestedNameSp

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; eduucaldas wrote: > gribozavr2 wrote: > > Should there be getters

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271744. eduucaldas marked 12 inline comments as done. eduucaldas added a comment. Aswering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/in

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:187 +/// A sequence of these specifiers make a `nested-name-specifier` +class NameSpecifier final : public Tree { Could you provide examples or a grammar quote in the comme

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271630. eduucaldas added a comment. Fix mistake on getting SourceRange for template-id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/T

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271620. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. - cleanup for upstreaming - better coverage for unqualified-id - Better coverage for qualified-id - Finish implementing unqualified-id. Repository: rG LLVM Github Monorepo

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked an inline comment as not done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; gribozavr2 wrote: > Should there be getters for various parts

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:209 +/// qualified-id: +/// nested-name-specifier template_opt unqualified-id +class IdExpression final : public Expression { Please add a TODO for the accessor for the 'te

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269422. eduucaldas edited the summary of this revision. eduucaldas added a comment. Answering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269423. eduucaldas added a comment. nswering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cl

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:618 + Builder.foldNode(Builder.getRange(it.getLocalSourceRange()), NS, nullptr); + Builder.markChild(NS, syntax::NodeRole::Unknown); +}

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; Should there be getters for various parts of the specifier? Comment at: clang/include/clang/

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269129. eduucaldas added a comment. cleanup for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cla