This revision was automatically updated to reflect the committed changes.
Closed by commit rG42f6fec3878d: Propose naming principle for NodeRole and
apply it (authored by eduucaldas, committed by gribozavr).
Changed prior to commit:
https://reviews.llvm.org/D81157?vs=268519&id=268543#toc
Repos
eduucaldas updated this revision to Diff 268517.
eduucaldas added a comment.
`ArrowToken`, `ExternKeyword`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81157/new/
https://reviews.llvm.org/D81157
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
eduucaldas updated this revision to Diff 268519.
eduucaldas added a comment.
fixed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81157/new/
https://reviews.llvm.org/D81157
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syn
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:110
+/// BinaryOperatorExpression_leftHandSide can only appear as a child of a
+/// BinaryOperatorExpression node.end with `NodeKind_` of the parent
enum class NodeRole : uint8_t {
-
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:124
IfStatement_thenStatement,
IfStatement_elseKeyword,
IfStatement_elseStatement,
eduucaldas wrote:
> gribozavr2 wrote:
> > Shouldn't `elseKeyword` have no prefix?
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94
/// a binary expression'. Used for implementing accessors.
+// How to name NodeRole:
+// If the child node is a token/keyword, end its name with 'Token'/'Keyword'
griboza
eduucaldas updated this revision to Diff 268502.
eduucaldas marked 2 inline comments as done.
eduucaldas added a comment.
Fix cout, add explanation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81157/new/
https://reviews.llvm.org/D81157
Files:
c
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94
/// a binary expression'. Used for implementing accessors.
+// How to name NodeRole:
+// If the child node is a token/keyword, end its name with 'Token'/'Keyword'
I'd sug
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D81157
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/N
