This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b739690b01e: Add support for IntegerLiteral in SyntaxTree
(authored by eduucaldas, committed by gribozavr).
Changed prior to commit:
https://reviews.llvm.org/D81135?vs=268428&id=268435#toc
Repository:
eduucaldas updated this revision to Diff 268428.
eduucaldas marked 4 inline comments as done.
eduucaldas added a comment.
Fix nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81135/new/
https://reviews.llvm.org/D81135
Files:
clang/include/clan
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:642
// TODO: add accessors for specifiers.
- syntax::Leaf *arrow();
+ syntax::Leaf *arrowToken();
syntax::SimpleDeclarator *declarator();
Could you move this change t
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:718
+}
+)cpp",
+ R"txt(
Could you remove the whitespace in front of `)cpp"` for
eduucaldas updated this revision to Diff 268420.
eduucaldas added a comment.
answering comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81135/new/
https://reviews.llvm.org/D81135
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/li
eduucaldas updated this revision to Diff 268403.
eduucaldas added a comment.
fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81135/new/
https://reviews.llvm.org/D81135
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Synta
eduucaldas updated this revision to Diff 268397.
eduucaldas added a comment.
answer comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81135/new/
https://reviews.llvm.org/D81135
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/T
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190
+ }
+ syntax::Leaf *literal();
+};
"literalToken"?
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:706
+void test() {
+ 42;
+}
-
eduucaldas updated this revision to Diff 268382.
eduucaldas added a comment.
Add support for IntegerLiteral in SyntaxTree
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81135/new/
https://reviews.llvm.org/D81135
Files:
clang/include/clang/Tooling
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D81135
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/N
10 matches
Mail list logo