This revision was automatically updated to reflect the committed changes.
Closed by commit rGd7d5dd31fc6f: Split syntax tree tests into more granular
ones (authored by gribozavr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81040/new/
https://revi
gribozavr updated this revision to Diff 268104.
gribozavr added a comment.
Address code review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81040/new/
https://reviews.llvm.org/D81040
Files:
clang/unittests/Tooling/Syntax/TreeTest.cpp
gribozavr updated this revision to Diff 268100.
gribozavr added a comment.
Refreshing this patch after pushing the patch that this one depends on.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81040/new/
https://reviews.llvm.org/D81040
Files:
cl
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066
+int func3b(int *);
+int func4(int a, float b);
+int func4a(int, float);
hlopko wrote:
> func4 -> func4a
> func4a -> func4b?
Fixed, thanks.
Repository:
rG LLVM Gith
hlopko accepted this revision.
hlopko added a comment.
Thanks for working on this! :)
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066
+int func3b(int *);
+int func4(int a, float b);
+int func4a(int, float);
func4 -> func4a
func4a -> func4b?
Repos
gribozavr created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
gribozavr2 added reviewers: hlopko, eduucaldas.
Doing so allows us to increase test coverage by removing unnecessary
language restrictions.
Repository:
rG LLVM Github Monorepo
https://revie
