[PATCH] D80988: [clangd] Copy existing includes in ReplayPreamble

2020-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8506877c87aa: [clangd] Copy existing includes in ReplayPreamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80988/new/ https://rev

[PATCH] D80988: [clangd] Copy existing includes in ReplayPreamble

2020-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 267848. kadircet marked an inline comment as done. kadircet added a comment. - Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80988/new/ https://reviews.llvm.org/D80988 Files: clang-tools-ext

[PATCH] D80988: [clangd] Copy existing includes in ReplayPreamble

2020-06-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:386 // Replay the preamble includes so that clang-tidy checks can see them. ReplayPreamble::attach(Incl

[PATCH] D80988: [clangd] Copy existing includes in ReplayPreamble

2020-06-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: sammccall, jkorous. Herald added subscribers: cfe-commits, usaxena95, arphaman, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. ReplayPreamble was just grabbing the reference of IncludeStructure passed to it and then rep