[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

2020-06-02 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG237be3404b44: [WebAssembly] Improve macro hygiene in wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80968/new/ https://

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

2020-06-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/wasm_simd128.h:1040 + (__c4)*2 + 1, (__c5)*2, (__c5)*2 + 1, (__c6)*2, (__c6)*2 + 1, (__c7)*2, \ + (__c7)*2 + 1)) ---

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

2020-06-01 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. The shuffle intrinsic macros did not parenthesize usages of their constant parameters, which could lead to incorrect