[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet abandoned this revision. kadircet added a comment. we've went with D81173 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80900/new/ https://reviews.llvm.org/D80900 __

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet added a comment. In D80900#2071207 , @sammccall wrote: > That makes sense. However I don't think that contract is conceptually that > great, having the ideas of "threadsafe FS" and "maybe-context-aware FS" > coupled together is... weird. The ben

[PATCH] D80900: [clangd] Use different FS in PreambleThread

sammccall added a comment. In D80900#2069566 , @kadircet wrote: > In D80900#2066327 , @sammccall wrote: > > > TL;DR: I think there are three viable paths that we should consider: > > A) minimal change: put the FSPr

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet added a comment. In D80900#2066327 , @sammccall wrote: > TL;DR: I think there are three viable paths that we should consider: > A) minimal change: put the FSProvider in ParseInputs > B) this patch, but with more documentation and safety > C) fi

[PATCH] D80900: [clangd] Use different FS in PreambleThread

sammccall added a comment. TL;DR: I think there are three viable paths that we should consider: A) minimal change: put the FSProvider in ParseInputs B) this patch, but with more documentation and safety C) fight to clean up VFS multithreading semantics Assuming we don't want to block on C, I'm no

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. As vfs::FileSystem is not threadsafe, we've introduced a data race when PreambleThread sta