nickdesaulniers updated this revision to Diff 267700.
nickdesaulniers added a comment.
- double backticks in release notes, -O1 rather than -O2 in tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80828/new/
https://reviews.llvm.org/D80828
Files
MaskRay added inline comments.
Comment at: clang/test/Driver/frame-pointer-elim.c:125
+// For Android, keep the framepointers always.
+// RUN: %clang -### -target armv7a-linux-androideabi- -marm -O2 -S %s 2>&1 | \
+// RUN: FileCheck --check-prefix=KEEP-ALL %s
`
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Thanks, Nick, for cleaning this up and always striving to make things more
compatible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80828/new
nickdesaulniers updated this revision to Diff 267683.
nickdesaulniers added a comment.
- update release note
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80828/new/
https://reviews.llvm.org/D80828
Files:
clang/lib/Basic/Targets/ARM.cpp
clang/
nickdesaulniers updated this revision to Diff 267682.
nickdesaulniers added a comment.
- prefer Triple#isAndroid
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80828/new/
https://reviews.llvm.org/D80828
Files:
clang/lib/Basic/Targets/ARM.cpp
cl
srhines added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:565
+case llvm::Triple::thumbeb:
+ if (Triple.getEnvironment() == llvm::Triple::Android)
+return true;
Triple.isAndroid() is more clear.
Comment a
nickdesaulniers updated this revision to Diff 267663.
nickdesaulniers added a comment.
- add Android target triple handling, see
https://developer.android.com/ndk/guides/other_build_systems#overview
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D808
nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22
#include "InputInfo.h"
+#include "MSP430.h"
#include "PS4CPU.h"
Note to reviewers: the linter really wanted to touch th
psmith added a comment.
FWIW I'm happy for Clang to match GCC behaviour for Linux (non-Android) targets
with respect to the frame pointer. Outside of Android I would expect most
developers of linux applications to build with both GCC and clang so they
should already have the -fno-omit-frame-poi
nickdesaulniers added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:560
// Don't use a frame pointer on linux if optimizing for certain targets.
+case llvm::Triple::arm:
+case llvm::Triple::armeb:
srhines wrote:
> For the new tar
srhines added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:560
// Don't use a frame pointer on linux if optimizing for certain targets.
+case llvm::Triple::arm:
+case llvm::Triple::armeb:
For the new targets, we should only be c
nickdesaulniers created this revision.
nickdesaulniers added reviewers: kristof.beyls, psmith, olista01.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
nickdesaulniers added a subscriber: vhscampos.
An upgrade of LLVM for CrOS [0] containing [1] triggered
12 matches
Mail list logo
