This revision was automatically updated to reflect the committed changes.
Closed by commit rG44f989e78096: Run syntax tree tests in many language modes
(authored by gribozavr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80822/new/
https://reviews
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:54-63
+ bool isCXX() const {
+return Language == Lang_CXX || Language == Lang_CXX11 ||
+ Language == Lang_CXX14 || Language == Lang_CXX17 ||
+ Language == Lang_CXX2a
gribozavr updated this revision to Diff 267814.
gribozavr added a comment.
Updated according to the code review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80822/new/
https://reviews.llvm.org/D80822
Files:
clang/unittests/Tooling/Syntax/CMake
eduucaldas added inline comments.
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:54-63
+ bool isCXX() const {
+return Language == Lang_CXX || Language == Lang_CXX11 ||
+ Language == Lang_CXX14 || Language == Lang_CXX17 ||
+ Language == Lang_CXX2a
hlopko accepted this revision.
hlopko added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80822/new/
https://reviews.llvm.org/D80822
__
gribozavr updated this revision to Diff 267351.
gribozavr added a comment.
Rebased the patch on top of the current master.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80822/new/
https://reviews.llvm.org/D80822
Files:
clang/unittests/Tooling/Sy
gribozavr created this revision.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.
gribozavr2 added reviewers: hlopko, eduucaldas.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D80822
Files:
clang/unittests/Tooling/Syntax/CMakeLists.txt
clang/unit
