[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

martong added a comment. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.org/D80786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ef654673a9: Rename APIs in unittests/AST/Language.h in preparation to share them (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D807

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr2 added a comment. In D80786#2062634 , @martong wrote: > Just out of curiosity. In what way do you prepare to share these test? For > which component are you planning to reuse this test infrastructure? Tests in clang/unittests/Tooling/Syntax/Tr

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr updated this revision to Diff 267188. gribozavr added a comment. Changed description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.org/D80786 Files: clang/unittests/AST/ASTImporterFixtures.cpp clang/u

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr2 added a comment. In D80786#2062557 , @sammccall wrote: > - Unittest -> Test (shorter, and unit test is two words, and llvm naming > conventions notwithstanding many gtests are not unit tests) Done. > - UnitTestClangArgs --> `std::vector` it'

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr updated this revision to Diff 267187. gribozavr added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.org/D80786 Files: clang/unittests/AST/ASTImporterFixtures.cpp c

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

martong added a comment. Just out of curiosity. In what way do you prepare to share these test? For which component are you planning to reuse this test infrastructure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80786/new/ https://reviews.llvm.o

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

martong added a comment. Thank you for working on this. > moving into a clang::test namespace instead of prefixing the names +1 for this. We could go even further: `clang::test::ast` or `clang::unittest::ast`. Comment at: clang/unittests/AST/Language.h:23 + +enum UnittestLan

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree with the rationale about moving the names out of `clang::ast_matchers`, and the names not being safe to put into `clang::` as-is. The names are a bit unwieldy though, and I wonder

[PATCH] D80786: Rename APIs in unittests/AST/Language.h in preparation to share them

gribozavr created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a reviewer: rengolin. Herald added a project: clang. Declaring these helpers in the ast_matcher namespace in the clangAST library seems inappropriate -- neither these help