This revision was automatically updated to reflect the committed changes.
Closed by commit rG406ac49fb05e: [clangd][NFC] Explode ReceivedPreamble into a
CV (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80784/new/
https://revi
kadircet updated this revision to Diff 269487.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Make distinction between PreambleCV and RequestsCV clearer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80784/new/
https://revie
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:661
+std::unique_lock Lock(Mutex);
+RequestsCV.wait(Lock, [this] {
+ // Block until we reiceve a preamble request, unless a preamble already
kadircet wrote:
> sammc
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:661
+std::unique_lock Lock(Mutex);
+RequestsCV.wait(Lock, [this] {
+ // Block until we reiceve a preamble request, unless a preamble alread
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:661
+std::unique_lock Lock(Mutex);
+RequestsCV.wait(Lock, [this] {
+ // Block until we reiceve a preamble request, unless a preamble already
Does LatestPreamble sig
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
javed.absar, ilya-biryukov.
Herald added a project: clang.
Instead of a notification, we make use of a CV and store the boolean on
LatestPreamble by
