MaskRay added a comment.
`arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:`
`Subscribers:` `Tags:` and the text `Summary:` with the following script:
arcfilter () {
arc amend
git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed
By:|Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7cfded350a7e: [PowerPC] Add clang option -m[no-]pcrel
(authored by lei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80757/new/
https://reviews.llvm.org/D
stefanp accepted this revision as: stefanp.
stefanp added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80757/new/
https://reviews.llvm.org/D80757
___
cfe-commits mailing list
cfe-comm
saghir added inline comments.
Comment at: clang/test/Driver/ppc-pcrel.cpp:1
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel
-o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr
lei marked an inline comment as done.
lei added inline comments.
Comment at: clang/test/Driver/ppc-pcrel.cpp:1
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel
-o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s
+// RUN: %clang -target powerpc64-
NeHuang accepted this revision as: NeHuang.
NeHuang added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80757/new/
https://reviews.llvm.org/D80757
___
cfe-commits mailing list
cfe-commi
saghir accepted this revision.
saghir added a comment.
This revision is now accepted and ready to land.
Other than the nit, this looks good to me.
Comment at: clang/test/Driver/ppc-pcrel.cpp:1
+// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel
-o %
lei created this revision.
lei added reviewers: stefanp, nemanjai, hfinkel, power-llvm-team.
Herald added subscribers: shchenz, wuzish.
Herald added a project: clang.
Add user-facing front end option to turn off pc-relative memops.
This will be compatible with gcc.
Repository:
rG LLVM Github M