[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4f2eb47636: [clang-tidy] remove duplicate fixes of alias checkers (authored by Daniel599, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 272052. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/Clang

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 3 inline comments as done. Daniel599 added a comment. I fixed all as your comments suggested, thanks :) If this patch is ready, can someone commit it on my behalf please? (I don't have write permissions) Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 accepted this revision. njames93 added a comment. LG, I have nothing else to add here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few small nits, but please wait a bit for @njames93 in case they have final thoughts. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagn

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added a comment. Any additional changes/fixes regarding this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777 + "or make sure they are both configured the same. " + "Aliased checkers: '{

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777 + "or make sure they are both configured the same. " + "Aliased checkers: '{0}', '{1}'", + Exist

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 268055. Daniel599 added a comment. Added `StringMap::operator!=` and also unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:4-8 +template +class initializer_list { +public: + initializer_list() noexcept {} +}; This isn't needed for the test case and can

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:250 void removeIncompatibleErrors(); + void removeDuplicatedFixesOfAliasCheckers(); maybe I need to rename this method since now it's removing the errors

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 2 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:51 bool IsWarningAsError; + std::vector EnabledDiagnosticAliases; }; njames93 wrote: > Just ignore this, but d

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267489. Daniel599 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsu

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added a comment. In D80753#2065067 , @Daniel599 wrote: > Thank you @njames93, I already started and took a bit different approach. > In case of a conflict, leaving it to clang-tidy itself didn't help as it > added both of the fix-its together re

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267478. Daniel599 added a comment. Thank you @njames93, I already started and took a bit different approach. In case of a conflict, leaving it to clang-tidy itself didn't help as it added both of the fix-its together resulting in `= 0{};`, so I thought it w

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added a comment. In D80753#2064857 , @Daniel599 wrote: > I have made the needed changes in order to detect a conflict in duplicated > fix-it of aliased checkers and also added a test for it. > Now I`ll try to work on combining aliased errors tog

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267455. Daniel599 added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. I have made the needed changes in order to detect a conflict in duplicated fix-it of aliased checkers and also added a test for it. Now I`ll

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added a comment. In D80753#2062586 , @aaron.ballman wrote: > In D80753#2061565 , @njames93 wrote: > > > It may be worth verifying that the fix-its are identical too, multiple > > versions of a check coul

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

aaron.ballman added a comment. In D80753#2061565 , @njames93 wrote: > It may be worth verifying that the fix-its are identical too, multiple > versions of a check could be running with differing options resulting in > different fix-its generated, in that

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267058. Daniel599 marked an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/Cl

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 4 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:3 + +#include +namespace std { Eugene.Zelenko wrote: > cstdio. Please also separate w

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267056. Daniel599 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangT

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added a comment. It may be worth verifying that the fix-its are identical too, multiple versions of a check could be running with differing options resulting in different fix-its generated, in that case we should let clang-tidy disable any conflicting fixes for us. Side note would it n

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:750 + for (auto &Error : Errors) { +auto Inserted = UniqueErrors.insert(&Error); + Please don't use auto when type is not spelled in same statement

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 created this revision. Daniel599 added reviewers: alexfh, hokein. Daniel599 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, Charusso, xazax.hun. Herald added a project: clang. when both a check and its alias are enabled, we should only take the fixes of one of