[PATCH] D80704: Remove WrapperMatcherInterface

2020-05-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG35492270ed70: Remove WrapperMatcherInterface (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80704/new/ https://reviews.llvm.org/D807

[PATCH] D80704: Remove WrapperMatcherInterface

2020-05-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Yes, thank you! There are (IMO) too many layers of abstractions in this framework; this is a good step in the right direction. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80704: Remove WrapperMatcherInterface

2020-05-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added subscribers: cfe-commits, arichardson. Herald added a project: clang. gribozavr2 added a reviewer: ymandel. WrapperMatcherInterface is an abstraction over a member variable -- in other words, not much of an abstraction at all. I think it makes code har