[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce5780b88c6e: [libTooling] Fix Transformer to work with ambient traversal kinds. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/n

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 266837. ymandel added a comment. more typo fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling/Transformer/RewriteRule.h clang/

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/RewriteRule.cpp:154 +const RewriteRule &Rule, +ast_type_traits::TraversalKind DefaultTraversalKind) { // Map the cases into buckets of matchers -- one for

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 266835. ymandel marked 2 inline comments as done. ymandel added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 266831. ymandel added a comment. updated per comments and after rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling/Transforme

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Transformer/RewriteRule.cpp:154 +const RewriteRule &Rule, +ast_type_traits::TraversalKind DefaultTraversalKind) { // Map the cases into buckets of matchers -- one for eac

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

2020-05-27 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 266729. ymandel added a comment. adds a fix to transformer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling/Transformer/RewriteRule.