MyDeveloperDay added a comment.
@JakeMerdichAMD are you still interested in landing this, if not I'm happy to
NFC it in over the next couple of weeks, if others agree
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80528/new/
https://reviews.llvm.o
HazardyKnusperkeks added a comment.
It says tests are failing. But generally this seems to be a good idea. So one
should take the tests one by one. I would do it, but currently I'm trying to
wrap my head around some of the internals, to get my requires clauses correctly
formatted. ;)
Reposito
MyDeveloperDay added subscribers: HazardyKnusperkeks, owenpan, curdeius.
MyDeveloperDay added a comment.
@HazardyKnusperkeks, @curdeius, @owenpan I feel we should try and get this
committed, people tend to follow the adjacent style of the unit tests, and I
sort of feel we keep having to ask peop
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
I think this is a noble effort, assuming all the tests pass as far as I'm
concerned this LGTM.
How about committing all the ones that pass, then work on the others that don't
