[PATCH] D80507: [clangd] Enable cross-file-rename by default.

2020-05-25 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG72c5ea1d73bb: [clangd] Enable cross-file-rename by default. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80507/new/ https://reviews.l

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

2020-05-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I suspect we're going to get some complaints from people whose index is perpetually behind and missing files, but this is the tradeoff of the design, we have to accept that or refine (e.

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

2020-05-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The cross-file rename feature is stable enough to enable it (has been rolled out internally for a few weeks).