[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-11-17 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D80499#2362028 , @steveire wrote: >> ! In D80499#2353187 , @alexfh wrote: >> You should be ready for back and forth with this change, if users hit >> widespread issues not caught by te

[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-10-29 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. > ! In D80499#2353187 , @alexfh wrote: > You should be ready for back and forth with this change, if users hit > widespread issues not caught by tests. Maybe splitting it into separate > pieces and involving check authors where

[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-10-26 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In D80499#2352339 , @steveire wrote: > @alexfh This change is based on the behavior of AST Matchers being changed to > ignore invisible/implicit AST nodes by default. As the default was not > changed in the end, this patch would n

[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-10-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a subscriber: alexfh. steveire added a comment. @alexfh This change is based on the behavior of AST Matchers being changed to ignore invisible/implicit AST nodes by default. As the default was not changed in the end, this patch would need to be updated to add `traverse(TK_IgnoreU

[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-05-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This is *great*, thank you for working on the cleanup! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80499/new/ https://revie

[PATCH] D80499: Remove obsolete ignore*() matcher uses

2020-05-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80499 Files: clang-tools-extra/clang-tidy/abseil/Duration