[PATCH] D80492: Avoid linking libdl unless needed

2020-06-08 Thread Tobias Hieta via Phabricator via cfe-commits
thieta added a comment. @lebedev.ri fix for your issue posted here: https://reviews.llvm.org/D81385 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-comm

[PATCH] D80492: Avoid linking libdl unless needed

2020-06-03 Thread Tobias Hieta via Phabricator via cfe-commits
thieta added a comment. Thanks - I'll look into a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D80492: Avoid linking libdl unless needed

2020-06-03 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. FYI as reported on IRC, this likely breaks standalone build of clang standalone builds of clang are still supported right ? commit 0073c293a401774ac96b4b3d27f05e13f379f98e seems to break them, since HAVE_LIBDL is not defined (it requires config-ix include from llv

[PATCH] D80492: Avoid linking libdl unless needed

2020-05-28 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0073c293a401: [clang] Avoid linking libdl unless needed (authored by thieta, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/

[PATCH] D80492: Avoid linking libdl unless needed

2020-05-28 Thread Tobias Hieta via Phabricator via cfe-commits
thieta added a comment. @mstorsjo mind landing this for me as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D80492: Avoid linking libdl unless needed

2020-05-27 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. looks reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 _

[PATCH] D80492: Avoid linking libdl unless needed

2020-05-25 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a reviewer: beanz. mstorsjo added a subscriber: beanz. mstorsjo added a comment. I think this is ok, but adding @beanz who knows the cmake conventions better than me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://

[PATCH] D80492: Avoid linking libdl unless needed

2020-05-25 Thread Tobias Hieta via Phabricator via cfe-commits
thieta created this revision. thieta added a reviewer: mstorsjo. thieta added a project: clang. Herald added subscribers: cfe-commits, mgorny. This fixes cross-compilation when targeting a platform not using libdl and mirrors libdl linking in other parts of the code. Repository: rG LLVM Githu