[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall closed this revision. rjmccall added a comment. To ssh://github.com/llvm/llvm-project a98d618f6e5f..7fac1acc6171 master -> master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 _

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale added a comment. As far as I can tell the failures reported shouldn't be caused by this change. John, would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 269417. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/include/clang/Basic/LangOptions.h clang/lib/C

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This looks great, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 __

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 269387. michele.scandale added a comment. Store `CGF` in RAII object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/include/clang/Basic/LangOp

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 269381. michele.scandale added a comment. Modify IR function attribute directly. RAII object modifies IR builder state and function attributes only if needed. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. We have a very similar problem with the constrained FP intrinsics where the use of the intrinsics anywhere in a function requires (1) an attribute to be set on the function and (2) all the other code in the function to be emitted with intrinsics. What I've been treati

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale added a comment. In D80462#2077569 , @rjmccall wrote: > Can we do this conservatively only if something is changed within the > function definition, and otherwise respect the global settings? I'm not sure I understand what you mean. The

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. Can we do this conservatively only if something is changed within the function definition, and otherwise respect the global settings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D8046

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 268667. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267907. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267783. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. I'll review this when it's rebased on top of the other commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 ___ cfe-commits mailing

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267125. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267122. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale created this revision. michele.scandale added reviewers: rjmccall, mibintc. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the support for changing the state of floating point optimizations within a code block, we need to make sure that the function at