[PATCH] D80454: [Clang][test] fix tests when using external assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a2df3bad07f: [Clang][test] fix tests when using external assembler. (authored by ychen). Changed prior to commit: https://reviews.llvm.org/D80454?vs=265792&id=266088#toc Repository: rG LLVM Github M

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen added a comment. In D80454#2051637 , @aganea wrote: > LGTM. > > Are you planning on adding another patch for the change that you've sent > initially? Ideally, I'd like to relax a bit that constraint in `Driver.cpp`, > as in D74447

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen added a comment. In D80454#2051668 , @MaskRay wrote: > In D80454#2051527 , @ychen wrote: > > > In D80454#2051524 , @aganea wrote: > > > > > Could you please attach a te

[PATCH] D80454: [Clang][test] fix tests when using external assembler

MaskRay added a comment. In D80454#2051527 , @ychen wrote: > In D80454#2051524 , @aganea wrote: > > > Could you please attach a test to demonstrate the issue? > > > When a toolchain is not using integrated-as, the t

[PATCH] D80454: [Clang][test] fix tests when using external assembler

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. Are you planning on adding another patch for the change that you've sent initially? Ideally, I'd like to relax a bit that constraint in `Driver.cpp`, as in D74447

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen updated this revision to Diff 265792. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 Files: clang/test/Driver/cc1-spawnprocess.c Index: clang/test/Driver/cc1-spawn

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen added a comment. In D80454#2051524 , @aganea wrote: > Could you please attach a test to demonstrate the issue? When a toolchain is not using integrated-as, the test would fail because using external assember would increase job counts. Most toolcha

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen updated this revision to Diff 265791. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 Files: clang/test/Driver/cc1-spawnprocess.c Index: clang/test/Driver/cc1-spawn

[PATCH] D80454: [Clang][test] fix tests when using external assembler

aganea added a comment. Could you please attach a test to demonstrate the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 ___ cfe-commits mailing list cf