This revision was automatically updated to reflect the committed changes.
Closed by commit rG8bd7e4188a09: Replace separator in OpenMP variant name
mangling. (authored by LukasSommerTu, committed by tianshilei1992).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
LukasSommerTu added a comment.
@jdoerfert: Can you please commit for me, I do not have commit access. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80439/new/
https://reviews.llvm.org/D80439
___
cfe-commits mailing list
cfe-commits@
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks a lot!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80439/new/
https://reviews.llvm.org/D80439
___
cfe-commits maili
LukasSommerTu added a comment.
@jdoerfert: I've added a test. I kept it focused on the variants for NVPTX
architecture (mangling is currently the same for all archs), let me know if
that was what you had in mind.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80439/new/
https://reviews
LukasSommerTu updated this revision to Diff 267902.
LukasSommerTu added a comment.
Added a small test checking for functions with the correctly mangled name.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80439/new/
https://reviews.llvm.org/D80439
Files:
clang/include/clang/AST/Decl.h
jdoerfert added a comment.
Changes looks good to me.
We don't have tests that check the mangling, interesting (and my fault), should
we add one?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80439/new/
https://reviews.llvm.org/D80439
_
LukasSommerTu created this revision.
LukasSommerTu added reviewers: jdoerfert, Hahnfeld.
LukasSommerTu added projects: OpenMP, clang.
Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl.
Nvidia PTX does not allow `.` to appear in identifiers, so OpenMP variant
mangling now uses `$`
