[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2021-01-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Such driver tests are in `clang/test/Driver/`. You may want to read a few existing mips driver tests and musl tests to figure out whether reusing an existing file or creating a new file makes more sense. You can run a test with `$build/bin/llvm-lit -vv test.c`. `check-c

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2021-01-21 Thread Joe Holden via Phabricator via cfe-commits
joewholden updated this revision to Diff 318346. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80421/new/ https://reviews.llvm.org/D80421 Files: clang/lib/Driver/ToolChains/Linux.cpp Index: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2021-01-21 Thread Joe Holden via Phabricator via cfe-commits
joewholden updated this revision to Diff 318343. joewholden added a comment. I think this is better (we've been using it for a while successfully), I haven't had time to understand the tests enough to add some yet, but I'll take a look as soon as I can CHANGES SINCE LAST ACTION https://revie

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2020-12-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D80421#2081794 , @joewholden wrote: > This is actually wrong anyway If it is wrong, it should be abandoned. If it is correct, can you add some tests under clang/test/Driver and test with `ninja check-clang-driver`? Repositor

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2020-06-09 Thread Joe Holden via Phabricator via cfe-commits
joewholden added a comment. This is actually wrong anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80421/new/ https://reviews.llvm.org/D80421 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2020-05-22 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan added a reviewer: atanasyan. atanasyan added a comment. 1. Please include as much context as possible with your diff. This instruction helps to do that. 2. Such patch needs test case(s). Maybe it's enoug

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2020-05-21 Thread Joe Holden via Phabricator via cfe-commits
joewholden created this revision. Herald added subscribers: cfe-commits, atanasyan, arichardson, sdardis. Herald added a project: clang. This patch attempts to fix the dynamic linker path for mips64-sf, I'm not entirely familiar with the llvm structure so I am unsure if this is the best way but