This revision was automatically updated to reflect the committed changes.
jyknight marked an inline comment as done.
Closed by commit rGaca3d067efe1: Fix Darwin 'constinit thread_local'
variables. (authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D80417?vs=265642&id=2665
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145
+ // referenced directly, without calling the thread-wrapper, so the linkage
+ // must not be changed.
+ //
-
hubert.reinterpretcast added subscribers: rsmith, hubert.reinterpretcast.
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145
+ // referenced directly, without calling the thread-wrapper, so the linkage
+ // must not be changed.
+
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145
+ // referenced directly, without calling the thread-wrapper, so the linkage
+ // must not be changed.
+ //
Is this a good idea? It seems to be making `constinit` part of the
jyknight created this revision.
jyknight added a reviewer: rjmccall.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Unlike other platforms using ItaniumCXXABI, Darwin does not allow the
creation of a thread-wrapper function for a variable in the TU of
users. Because of this
