[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2023-01-05 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D80392#4028011 , @wzssyqa wrote: > When link with ld.bfd, we get: > > ld/ld-new: .eh_frame_hdr entry overflow > ld/ld-new: final link failed: bad value > > It seems due to the `initial_loc` in the object from LLVM is quite b

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2023-01-05 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. When link with ld.bfd, we get: ld/ld-new: .eh_frame_hdr entry overflow ld/ld-new: final link failed: bad value It seems due to the `initial_loc` in the object from LLVM is quite big than the gcc/gas one. initial_loc: 0x10cd0, vma: 0xe78 Repository: rG L

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2022-11-09 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. In D80392#3876782 , @wzssyqa wrote: > I don't think that we need that option: what we need to do is to update the > old tools. the ld.bfd support R_MIPS_PC32 here. I think that we can just switch the behavior without any condtion

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2022-10-22 Thread YunQiang Su via Phabricator via cfe-commits
wzssyqa added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. I don't think that we need that option: what we need to do is to update the old tools. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80392/new/ https://re

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2021-08-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. If you want to do this proper, you may look at how -fbinutils-version= was implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80392/new/ https://reviews.llvm.org/D80392

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2021-08-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. `MCTargetOptionsCommandFlags.cpp` may be a better place for the internal cl::opt option. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:30 +cl::opt +MipsPC64Re

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

2021-08-19 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan updated this revision to Diff 367472. atanasyan retitled this revision from "[WIP][mips] Use pc-relative relocations in .eh_frame" to "[mips][mc][clang] Use pc-relative relocations in .eh_frame". atanasyan edited the summary of this revision. atanasyan edited reviewers, added: emaste, gr