[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Ten Tzen via Phabricator via cfe-commits
tentzen marked 3 inline comments as done. tentzen added a comment. In D80344#2051127 , @lebedev.ri wrote: > This should likely be at least 3 patches: llvm middle-end, llvm codegen, > clang. > Langref changes missing for new intrinsics. > Please post all

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. This should likely be at least 3 patches: llvm middle-end, llvm codegen, clang. Langref changes missing for new intrinsics. Please post all patches with full context (`-U9`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Aaron Smith via Phabricator via cfe-commits
asmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2003 +// : Under -EHa, Invoke llvm.eha.scope.begin() right after +// Ctor is emitted and EHStack.pushCleanup Nit - remove name Comment at: clang/lib/CodeGen/C

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Ten Tzen via Phabricator via cfe-commits
tentzen updated this revision to Diff 265672. tentzen added a comment. avoid lint warnings and lint hang on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-21 Thread Ten Tzen via Phabricator via cfe-commits
tentzen updated this revision to Diff 265442. tentzen added a comment. fixed formats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/LangO

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-20 Thread Ten Tzen via Phabricator via cfe-commits
tentzen created this revision. tentzen added reviewers: andrew.w.kaylor, rnk, majnemer, pengfei, eli.friedman, JosephTremoulet, asmith. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, kbarton, hiraditya, kristof.beyls, nemanjai. Herald added projects: clang, LLVM. This patch adds