[PATCH] D80294: Add support for vmsumudm

2020-05-22 Thread Kamau Bridgeman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa28e9f120860: [PowerPC] Add support for vmsumudm (authored by saghir, committed by kamaub). Changed prior to commit: https://reviews.llvm.org/D80294?vs=265332&id=265790#toc Repository: rG LLVM Github

[PATCH] D80294: Add support for vmsumudm

2020-05-22 Thread Amy Kwan via Phabricator via cfe-commits
amyk accepted this revision. amyk added a comment. Thanks for explaining. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D80294: Add support for vmsumudm

2020-05-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-comm

[PATCH] D80294: Add support for vmsumudm

2020-05-21 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir marked an inline comment as done. saghir added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, amyk wrote: > Maybe we can put this

[PATCH] D80294: Add support for vmsumudm

2020-05-21 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, Maybe we can put this definition near the other VMSUM instructions? Since it's

[PATCH] D80294: Add support for vmsumudm

2020-05-21 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir added a comment. In D80294#2048049 , @amyk wrote: > I think this overall looks good, but just curious, why was the builtin > support removed? I was hitting some errors with that, so removed it and would add that later on. CHANGES SINCE LAST ACT

[PATCH] D80294: Add support for vmsumudm

2020-05-20 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. I think this overall looks good, but just curious, why was the builtin support removed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-commits

[PATCH] D80294: Add support for vmsumudm

2020-05-20 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 265332. saghir edited the summary of this revision. saghir added a comment. Removing the builtin support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 Files: clang/include/clang/Basic/BuiltinsPPC.def l

[PATCH] D80294: Add support for vmsumudm

2020-05-20 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 265281. saghir added a comment. Added vec_msum builtin for vmsumudm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/te

[PATCH] D80294: Add support for vmsumudm

2020-05-20 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir created this revision. saghir added reviewers: power-llvm-team, nemanjai, stefanp, amyk, lei, hfinkel, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch adds support for Vector Multiply-Sum Unsigned Doubleword Modulo in