[PATCH] D80289: [Driver][X86] Support branch align options with LTO

This revision was automatically updated to reflect the committed changes. skan marked an inline comment as done. Closed by commit rG495444999549: [Driver][X86] Support branch align options with LTO (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/x86-malign-branch.c:6 // BOUNDARY: "-mllvm" "-x86-align-branch-boundary=16" +// RUN: %clang -target x86_64-unknown-linux -malign-branch-b

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan marked an inline comment as done. skan added inline comments. Comment at: clang/test/Driver/x86-malign-branch.c:6 // BOUNDARY: "-mllvm" "-x86-align-branch-boundary=16" +// RUN: %clang -target x86_64-unknown-linux -malign-branch-boundary=16 -flto %s -### 2>&1 | FileCheck %s

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added a comment. In D80289#2051947 , @skan wrote: > Ping. `https://reviews.llvm.org/D80168#2046093` "Unless something is urgent, the usual practice is to ping after a week rather than 24 hours, as many people have big piles on their review plat

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80289/new/ https://reviews.llvm.org/D80289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan updated this revision to Diff 265423. skan marked an inline comment as done. skan added a comment. Refactor addX86AlignBranchArgs to be reused in CommonArgs.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80289/new/ https://reviews.llvm.org/

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan updated this revision to Diff 265408. skan marked an inline comment as done. skan added a comment. Move tests to x86-malign-branch.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80289/new/ https://reviews.llvm.org/D80289 Files: clang/lib/D

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:501 + // Handle options for branch align + if (Args.hasArg(options::OPT_mbranches_within_32B_boundaries)) { +CmdArgs.push_back("-plugin-opt=-x86-branches-within-32B-boundaries"); -

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added inline comments. Comment at: clang/test/Driver/lto.c:81 + +/// -flto passes along an explicit branch align argument. +/// Test -malign-branch-boundary= This piece of logic is closer to x86. The test can be added to `x86-malign-branch.c` instead R

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80289 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/lto.c Ind