[PATCH] D80210: [analyzer] Turn off reports in system headers

2020-06-24 Thread Tibor Brunner via Phabricator via cfe-commits
bruntib added a comment. Hi, Thanks everyone for the investigation in this problem. I find these suggestions reasonable, and I think this commented example is a strong beating card in our hands to convince our users that paths going through system headers are meaningful and important. I'll star

[PATCH] D80210: [analyzer] Turn off reports in system headers

2020-06-08 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. (if we agree to do this, the next obvious experiment would be to cut out the beginning of the path from the report we *do* emit - i.e., everything until our first interesting stack frame) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D80210: [analyzer] Turn off reports in system headers

2020-06-08 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Sounds nice. @bruntib, would this be sufficient for the user's request? Are we sure that the actual request makes sense in light of the analyzer's viewpoint? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80210/new/ https

[PATCH] D80210: [analyzer] Turn off reports in system headers

2020-06-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Eg., suppress this report: // system_header.h int bar() { int *x = NULL; return *x; } // user_file.c void foo() { bar(); } but don't suppress this report: // system_header.h int bar(int *x) { return *x; } // user_file.c void foo() {