[PATCH] D80198: [clangd] locateMacroAt handles patched macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG538c2753f3ec: [clangd] locateMacroAt handles patched macros (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266639. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Hov

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266187. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Hov

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266128. kadircet marked 4 inline comments as done. kadircet added a comment. - Add tests for preamble-patch translation logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks great, ship it! Comment at: clang-tools-extra/clangd/Preamble.cpp:154 +OS << "\\\n" << std::string(TargetColumn, ' '); +// Decrement because returned stri

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:133 + auto DecompLoc = SM.getDecomposedLoc(DirectiveRange.getBegin()); + DirectiveLine = SM.getLineNumber(DecompLoc.first, DecompLoc.second); + auto SpaceBefore = SM.getColumnNumber(DecompLoc.fir

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266111. kadircet marked 10 inline comments as done. kadircet added a comment. - Extract preamble-patch location translation to a helper: - Migrate usage in include collector - Make preamble patch header name part of the check. - Handle macro ids in spellD

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added a comment. (BTW this looks miles better to me, thanks for persistence!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 ___ cfe-commits mailing

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:123 +// Spells directive in \p DirectiveRange while prepending it with \p Prefix. +// Returned string can be used with a #line directive on line \p DirectiveLine > Spells directi

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266047. kadircet marked 3 inline comments as done. kadircet added a comment. Instead of re-lexing at use time, put macro identifier on correct column while patching and make use of presumed locations at use time. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:975 + + // Macro definitions could be injected through preamble patch. These contain + // line directives to hint their original location in main file. OK, this is fairly horri

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 265195. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Hov

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 265181. kadircet added a comment. - Polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Hov

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D79992 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80198 Files: clang