[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

hans added a comment. Alok, Adrian: please work on addressing the concerns raised in https://bugs.llvm.org/show_bug.cgi?id=47287, or please revert this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80197/new/ https://reviews.llvm.org/D8019

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

cuviper added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1595 const DISubrange *Subrange = cast(Element); -assert(Subrange->getLowerBound() == 0 && +assert(!Subrange->getRawLowerBound() && "codeview doesn't support subrange

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked 2 inline comments as done. alok added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1522 static uint64_t rotateSign(int64_t I) { uint64_t U = I; melver wrote: > rotateSign() is no longer used in this file. If there are n

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked an inline comment as done. alok added a comment. In D80197#2059591 , @thakis wrote: > This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt > > Please take a look and revert if it takes a while to investigate. Fixed in 7

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

melver added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1522 static uint64_t rotateSign(int64_t I) { uint64_t U = I; rotateSign() is no longer used in this file. If there are no plans to use it again, please remove it. Thanks!

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

thakis added a comment. This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt Please take a look and revert if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80197/new/ https://reviews.llvm.org

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGd20bf5a7258d: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays (authored by alok, committed by SouraVX). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prio