[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

2020-05-19 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3181273be73a: [WebAssembly] Implement i64x2.mul and remove i8x16.mul (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80174/new/ https:/

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

2020-05-19 Thread Thomas Lively via Phabricator via cfe-commits
tlively marked 2 inline comments as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:690 defm "" : SIMDBinary; } aheejin wrote: > Can we delete this now then? No, it is still used down in MIN_S and friends

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

2020-05-18 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:690 defm "" : SIMDBinary; } Can we delete this now then? Comme

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

2020-05-18 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This reflects changes in the spec proposal made since basic arithmetic was first implem